Skip to content

Commit a5f813e

Browse files
Uwe Kleine-Königmathieupoirier
authored andcommitted
remoteproc: qcom_q6v5_mss: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Reviewed-by: Caleb Connolly <caleb.connolly@linaro.org> Link: https://lore.kernel.org/r/20230504194453.1150368-11-u.kleine-koenig@pengutronix.de Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
1 parent 52c8009 commit a5f813e

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/remoteproc/qcom_q6v5_mss.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2110,7 +2110,7 @@ static int q6v5_probe(struct platform_device *pdev)
21102110
return ret;
21112111
}
21122112

2113-
static int q6v5_remove(struct platform_device *pdev)
2113+
static void q6v5_remove(struct platform_device *pdev)
21142114
{
21152115
struct q6v5 *qproc = platform_get_drvdata(pdev);
21162116
struct rproc *rproc = qproc->rproc;
@@ -2128,8 +2128,6 @@ static int q6v5_remove(struct platform_device *pdev)
21282128
q6v5_pds_detach(qproc, qproc->proxy_pds, qproc->proxy_pd_count);
21292129

21302130
rproc_free(rproc);
2131-
2132-
return 0;
21332131
}
21342132

21352133
static const struct rproc_hexagon_res sc7180_mss = {
@@ -2482,7 +2480,7 @@ MODULE_DEVICE_TABLE(of, q6v5_of_match);
24822480

24832481
static struct platform_driver q6v5_driver = {
24842482
.probe = q6v5_probe,
2485-
.remove = q6v5_remove,
2483+
.remove_new = q6v5_remove,
24862484
.driver = {
24872485
.name = "qcom-q6v5-mss",
24882486
.of_match_table = q6v5_of_match,

0 commit comments

Comments
 (0)