Skip to content

Commit a69c610

Browse files
arndbalexandrebelloni
authored andcommitted
rtc: stm32: remove incorrect #ifdef check
After a previous commit changed the driver over to SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(), the suspend/resume functions must no longer be hidden behind an #ifdef: In file included from include/linux/clk.h:13, from drivers/rtc/rtc-stm32.c:8: drivers/rtc/rtc-stm32.c:927:39: error: 'stm32_rtc_suspend' undeclared here (not in a function); did you mean 'stm32_rtc_probe'? 927 | SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume) | ^~~~~~~~~~~~~~~~~ include/linux/kernel.h:58:44: note: in definition of macro 'PTR_IF' 58 | #define PTR_IF(cond, ptr) ((cond) ? (ptr) : NULL) | ^~~ include/linux/pm.h:329:26: note: in expansion of macro 'pm_sleep_ptr' 329 | .suspend_noirq = pm_sleep_ptr(suspend_fn), \ | ^~~~~~~~~~~~ Fixes: fb9a7e5 ("rtc: stm32: change PM callbacks to "_noirq()"") Signed-off-by: Arnd Bergmann <arnd@arndb.de> Reviewed-by: Valentin Caron <valentin.caron@foss.st.com> Link: https://lore.kernel.org/r/20230801105932.3738430-1-arnd@kernel.org Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 58f3e83 commit a69c610

1 file changed

Lines changed: 0 additions & 2 deletions

File tree

drivers/rtc/rtc-stm32.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -891,7 +891,6 @@ static void stm32_rtc_remove(struct platform_device *pdev)
891891
device_init_wakeup(&pdev->dev, false);
892892
}
893893

894-
#ifdef CONFIG_PM_SLEEP
895894
static int stm32_rtc_suspend(struct device *dev)
896895
{
897896
struct stm32_rtc *rtc = dev_get_drvdata(dev);
@@ -922,7 +921,6 @@ static int stm32_rtc_resume(struct device *dev)
922921

923922
return ret;
924923
}
925-
#endif
926924

927925
static const struct dev_pm_ops stm32_rtc_pm_ops = {
928926
SET_NOIRQ_SYSTEM_SLEEP_PM_OPS(stm32_rtc_suspend, stm32_rtc_resume)

0 commit comments

Comments
 (0)