Skip to content

Commit a6a1a15

Browse files
chunkeeyffainelli
authored andcommitted
ARM: dts: BCM5301X: MR26: MR32: remove bogus nand-ecc-algo property
| bcm53015-meraki-mr26.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml | bcm53016-meraki-mr32.dtb: nand-controller@18028000: | nand@0:nand-ecc-algo:0: 'hw' is not one of ['hamming', 'bch', 'rs'] | From schema: Documentation/[...]/nand-controller.yaml original ECC values for these old Merakis are sadly not provided by the vendor. It looks like Meraki just stuck with what Broadcom's SDK was doing... which left this up to the proprietary nand driver. Note: The invalid setting was and is handled by brcmnand. It falls back to "bch" in brcmnand_setup_dev() when ecc.algo is set to NAND_ECC_ALGO_UNKNOWN (since "hw" is not in the list above). A correct nand-ecc-algo = "bch"; is already specified in the included "bcm5301x-nand-cs0-bch8.dtsi". So this line can be dropped. Reported-by: Rafał Miłecki <zajec5@gmail.com> (per Mail) Fixes: 935327a ("ARM: dts: BCM5301X: Add DT for Meraki MR26") Fixes: ec88a9c ("ARM: BCM5301X: Add DT for Meraki MR32") Signed-off-by: Christian Lamparter <chunkeey@gmail.com> Link: https://lore.kernel.org/r/2c4d00dd40124c2ddc0b139cbce7531b108f9052.1686238550.git.chunkeey@gmail.com Signed-off-by: Florian Fainelli <florian.fainelli@broadcom.com>
1 parent 7121458 commit a6a1a15

2 files changed

Lines changed: 0 additions & 4 deletions

File tree

arch/arm/boot/dts/bcm53015-meraki-mr26.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,8 +72,6 @@
7272
};
7373

7474
&nandcs {
75-
nand-ecc-algo = "hw";
76-
7775
partitions {
7876
compatible = "fixed-partitions";
7977
#address-cells = <0x1>;

arch/arm/boot/dts/bcm53016-meraki-mr32.dts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,6 @@
125125
};
126126

127127
&nandcs {
128-
nand-ecc-algo = "hw";
129-
130128
partitions {
131129
/*
132130
* The partition autodetection does not work for this device.

0 commit comments

Comments
 (0)