Skip to content

Commit a6e1445

Browse files
jwrdegoederafaeljw
authored andcommitted
i2c: acpi: Do not instantiate I2C-clients on boards with known bogus DSDT entries
x86 ACPI devices which ship with only Android as their factory image usually declare a whole bunch of bogus I2C devices in their ACPI tables. Instantiating I2C clients for these bogus devices causes various issues, e.g. GPIO/IRQ resource conflicts because sometimes drivers do bind to them. The Android x86 kernel fork shipped on these devices has some special code to remove these bogus devices, instead of just fixing the DSDT <sigh>. Use the new acpi_quirk_skip_i2c_client_enumeration() helper to identify known boards / acpi devices with this issue, and skip enumerating these. Note these boards typically do actually have I2C devices, just different ones then the ones described in their DSDT. The devices which are actually present are manually instantiated by the drivers/platform/x86/x86-android-tablets.c kernel module. Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Reviewed-by: Wolfram Sang <wsa@kernel.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 35f9e77 commit a6e1445

1 file changed

Lines changed: 7 additions & 0 deletions

File tree

drivers/i2c/i2c-core-acpi.c

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -254,6 +254,13 @@ static void i2c_acpi_register_device(struct i2c_adapter *adapter,
254254
struct acpi_device *adev,
255255
struct i2c_board_info *info)
256256
{
257+
/*
258+
* Skip registration on boards where the ACPI tables are
259+
* known to contain bogus I2C devices.
260+
*/
261+
if (acpi_quirk_skip_i2c_client_enumeration(adev))
262+
return;
263+
257264
adev->power.flags.ignore_parent = true;
258265
acpi_device_set_enumerated(adev);
259266

0 commit comments

Comments
 (0)