Skip to content

Commit a770dc6

Browse files
konradybciorobclark
authored andcommitted
dt-bindings: display/msm: gpu: Document GMU wrapper-equipped A6xx
The "GMU Wrapper" is Qualcomm's name for "let's treat the GPU blocks we'd normally assign to the GMU as if they were a part of the GMU, even though they are not". It's a (good) software representation of the GMU_CX and GMU_GX register spaces within the GPUSS that helps us programatically treat these de-facto GMU-less parts in a way that's very similar to their GMU-equipped cousins, massively saving up on code duplication. The "wrapper" register space was specifically designed to mimic the layout of a real GMU, though it rather obviously does not have the M3 core et al. GMU wrapper-equipped A6xx GPUs require clocks and clock-names to be specified under the GPU node, just like their older cousins. Account for that. Acked-by: Rob Herring <robh@kernel.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org> Patchwork: https://patchwork.freedesktop.org/patch/542748/ Signed-off-by: Rob Clark <robdclark@chromium.org>
1 parent 452c46c commit a770dc6

1 file changed

Lines changed: 52 additions & 9 deletions

File tree

  • Documentation/devicetree/bindings/display/msm

Documentation/devicetree/bindings/display/msm/gpu.yaml

Lines changed: 52 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,10 +36,7 @@ properties:
3636

3737
reg-names:
3838
minItems: 1
39-
items:
40-
- const: kgsl_3d0_reg_memory
41-
- const: cx_mem
42-
- const: cx_dbgc
39+
maxItems: 3
4340

4441
interrupts:
4542
maxItems: 1
@@ -157,16 +154,62 @@ allOf:
157154
required:
158155
- clocks
159156
- clock-names
157+
160158
- if:
161159
properties:
162160
compatible:
163161
contains:
164-
pattern: '^qcom,adreno-6[0-9][0-9]\.[0-9]$'
165-
166-
then: # Since Adreno 6xx series clocks should be defined in GMU
162+
enum:
163+
- qcom,adreno-610.0
164+
- qcom,adreno-619.1
165+
then:
167166
properties:
168-
clocks: false
169-
clock-names: false
167+
clocks:
168+
minItems: 6
169+
maxItems: 6
170+
171+
clock-names:
172+
items:
173+
- const: core
174+
description: GPU Core clock
175+
- const: iface
176+
description: GPU Interface clock
177+
- const: mem_iface
178+
description: GPU Memory Interface clock
179+
- const: alt_mem_iface
180+
description: GPU Alternative Memory Interface clock
181+
- const: gmu
182+
description: CX GMU clock
183+
- const: xo
184+
description: GPUCC clocksource clock
185+
186+
reg-names:
187+
minItems: 1
188+
items:
189+
- const: kgsl_3d0_reg_memory
190+
- const: cx_dbgc
191+
192+
required:
193+
- clocks
194+
- clock-names
195+
else:
196+
if:
197+
properties:
198+
compatible:
199+
contains:
200+
pattern: '^qcom,adreno-6[0-9][0-9]\.[0-9]$'
201+
202+
then: # Starting with A6xx, the clocks are usually defined in the GMU node
203+
properties:
204+
clocks: false
205+
clock-names: false
206+
207+
reg-names:
208+
minItems: 1
209+
items:
210+
- const: kgsl_3d0_reg_memory
211+
- const: cx_mem
212+
- const: cx_dbgc
170213

171214
examples:
172215
- |

0 commit comments

Comments
 (0)