Skip to content

Commit a7a7263

Browse files
liwg06acmel
authored andcommitted
perf parse-events: Fix NULL check against wrong variable
We did a null check after "tmp->symbol = strdup(...)", but we checked "list->symbol" other than "tmp->symbol". Reviewed-by: John Garry <john.garry@huawei.com> Signed-off-by: Weiguo Li <liwg06@foxmail.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Ingo Molnar <mingo@redhat.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Mark Rutland <mark.rutland@arm.com> Cc: Namhyung Kim <namhyung@kernel.org> Cc: Peter Zijlstra <peterz@infradead.org> Link: https://lore.kernel.org/r/tencent_DF39269807EC9425E24787E6DB632441A405@qq.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent ec9d50a commit a7a7263

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/util/parse-events.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2193,7 +2193,7 @@ int perf_pmu__test_parse_init(void)
21932193
for (i = 0; i < ARRAY_SIZE(symbols); i++, tmp++) {
21942194
tmp->type = symbols[i].type;
21952195
tmp->symbol = strdup(symbols[i].symbol);
2196-
if (!list->symbol)
2196+
if (!tmp->symbol)
21972197
goto err_free;
21982198
}
21992199

0 commit comments

Comments
 (0)