Skip to content

Commit a7fb84e

Browse files
Sebastian Andrzej SiewiorThomas Gleixner
authored andcommitted
usb: typec: fusb302: Remove IRQF_ONESHOT
Passing IRQF_ONESHOT ensures that the interrupt source is masked until the secondary (threaded) handler is done. If only a primary handler is used then the flag makes no sense because the interrupt can not fire (again) while its handler is running. The flag also prevents force-threading of the primary handler and the irq-core will warn about this. Remove IRQF_ONESHOT from irqflags. Fixes: 309b634 ("usb: typec: fusb302: Revert incorrect threaded irq fix") Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de> Signed-off-by: Thomas Gleixner <tglx@kernel.org> Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://patch.msgid.link/20260128095540.863589-12-bigeasy@linutronix.de
1 parent 5c858d6 commit a7fb84e

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/usb/typec/tcpm/fusb302.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1756,8 +1756,7 @@ static int fusb302_probe(struct i2c_client *client)
17561756
}
17571757

17581758
ret = request_irq(chip->gpio_int_n_irq, fusb302_irq_intn,
1759-
IRQF_ONESHOT | IRQF_TRIGGER_LOW,
1760-
"fsc_interrupt_int_n", chip);
1759+
IRQF_TRIGGER_LOW, "fsc_interrupt_int_n", chip);
17611760
if (ret < 0) {
17621761
dev_err(dev, "cannot request IRQ for GPIO Int_N, ret=%d", ret);
17631762
goto tcpm_unregister_port;

0 commit comments

Comments
 (0)