Skip to content

Commit a857d99

Browse files
hoeppnerjaxboe
authored andcommitted
s390/dasd: Use scnprintf() instead of sprintf()
Use scnprintf() instead of sprintf() for those cases where the destination is an array and the size of the array is known at compile time. This prevents theoretical buffer overflows, but also avoids that people again and again spend time to figure out if the code is actually safe. Signed-off-by: Jan Höppner <hoeppner@linux.ibm.com> Reviewed-by: Stefan Haberland <sth@linux.ibm.com> Signed-off-by: Stefan Haberland <sth@linux.ibm.com> Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 4319875 commit a857d99

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

drivers/s390/block/dasd_devmap.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -355,7 +355,8 @@ static int __init dasd_parse_range(const char *range)
355355
/* each device in dasd= parameter should be set initially online */
356356
features |= DASD_FEATURE_INITIAL_ONLINE;
357357
while (from <= to) {
358-
sprintf(bus_id, "%01x.%01x.%04x", from_id0, from_id1, from++);
358+
scnprintf(bus_id, sizeof(bus_id),
359+
"%01x.%01x.%04x", from_id0, from_id1, from++);
359360
devmap = dasd_add_busid(bus_id, features);
360361
if (IS_ERR(devmap)) {
361362
rc = PTR_ERR(devmap);

0 commit comments

Comments
 (0)