Skip to content

Commit a876f99

Browse files
Uwe Kleine-Königrafaeljw
authored andcommitted
thermal: int3406: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Acked-by: Daniel Lezcano <daniel.lezcano@linaro.org> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 2570108 commit a876f99

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/thermal/intel/int340x_thermal/int3406_thermal.c

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -178,13 +178,12 @@ static int int3406_thermal_probe(struct platform_device *pdev)
178178
return -ENODEV;
179179
}
180180

181-
static int int3406_thermal_remove(struct platform_device *pdev)
181+
static void int3406_thermal_remove(struct platform_device *pdev)
182182
{
183183
struct int3406_thermal_data *d = platform_get_drvdata(pdev);
184184

185185
thermal_cooling_device_unregister(d->cooling_dev);
186186
kfree(d->br);
187-
return 0;
188187
}
189188

190189
static const struct acpi_device_id int3406_thermal_match[] = {
@@ -196,7 +195,7 @@ MODULE_DEVICE_TABLE(acpi, int3406_thermal_match);
196195

197196
static struct platform_driver int3406_thermal_driver = {
198197
.probe = int3406_thermal_probe,
199-
.remove = int3406_thermal_remove,
198+
.remove_new = int3406_thermal_remove,
200199
.driver = {
201200
.name = "int3406 thermal",
202201
.acpi_match_table = int3406_thermal_match,

0 commit comments

Comments
 (0)