Skip to content

Commit a900cac

Browse files
Hermann Lauermripard
authored andcommitted
ARM: dts: sun7i: a20: bananapro: Fix ethernet phy-mode
BPi Pro needs TX and RX delay for Gbit to work reliable and avoid high packet loss rates. The realtek phy driver overrides the settings of the pull ups for the delays, so fix this for BananaPro. Fix the phy-mode description to correctly reflect this so that the implementation doesn't reconfigure the delays incorrectly. This happened with commit bbc4d71 ("net: phy: realtek: fix rtl8211e rx/tx delay config"). Fixes: 10662a3 ("ARM: dts: sun7i: Add dts file for Bananapro board") Signed-off-by: Hermann Lauer <Hermann.Lauer@uni-heidelberg.de> Signed-off-by: Maxime Ripard <maxime@cerno.tech> Link: https://lore.kernel.org/r/20210128111842.GA11919@lemon.iwr.uni-heidelberg.de
1 parent 530fe6b commit a900cac

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

arch/arm/boot/dts/sun7i-a20-bananapro.dts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,7 +110,7 @@
110110
pinctrl-names = "default";
111111
pinctrl-0 = <&gmac_rgmii_pins>;
112112
phy-handle = <&phy1>;
113-
phy-mode = "rgmii";
113+
phy-mode = "rgmii-id";
114114
phy-supply = <&reg_gmac_3v3>;
115115
status = "okay";
116116
};

0 commit comments

Comments
 (0)