Skip to content

Commit a9e42d9

Browse files
simontrimmerbroonie
authored andcommitted
ASoC: cs35l56: Remove duplicate mbox log messages
cs35l56_mbox_send() logs a warning when sending a mbox command fails so the callers can be simplified. Signed-off-by: Simon Trimmer <simont@opensource.cirrus.com> Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com> Link: https://lore.kernel.org/r/20230420102043.1151830-1-rf@opensource.cirrus.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 2cc3fdc commit a9e42d9

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

sound/soc/codecs/cs35l56.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -859,10 +859,8 @@ static void cs35l56_dsp_work(struct work_struct *work)
859859
}
860860

861861
ret = cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_SHUTDOWN);
862-
if (ret) {
863-
dev_dbg(cs35l56->dev, "%s: CS35L56_MBOX_CMD_SHUTDOWN ret %d\n", __func__, ret);
862+
if (ret)
864863
goto err;
865-
}
866864

867865
if (cs35l56->rev < CS35L56_REVID_B0)
868866
reg = CS35L56_DSP1_PM_CUR_STATE_A1;
@@ -1033,9 +1031,7 @@ int cs35l56_runtime_suspend(struct device *dev)
10331031
* Enable auto-hibernate. If it is woken by some other wake source
10341032
* it will automatically return to hibernate.
10351033
*/
1036-
ret = cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_ALLOW_AUTO_HIBERNATE);
1037-
if (ret)
1038-
dev_warn(cs35l56->dev, "ALLOW_HIBERNATE failed: %d\n", ret);
1034+
cs35l56_mbox_send(cs35l56, CS35L56_MBOX_CMD_ALLOW_AUTO_HIBERNATE);
10391035

10401036
/*
10411037
* Must enter cache-only first so there can't be any more register

0 commit comments

Comments
 (0)