Skip to content

Commit aa28514

Browse files
jwrdegoedeLinus Walleij
authored andcommitted
pinctrl: cherryview: Trigger hwirq0 for interrupt-lines without a mapping
Commit bdfbef2 ("pinctrl: cherryview: Don't use selection 0 to mark an interrupt line as unused") made the code properly differentiate between unset vs (hwirq) 0 entries in the GPIO-controller interrupt-line to GPIO pinnumber/hwirq mapping. This is causing some boards to not boot. This commit restores the old behavior of triggering hwirq 0 when receiving an interrupt on an interrupt-line for which there is no mapping. Fixes: bdfbef2 ("pinctrl: cherryview: Don't use selection 0 to mark an interrupt line as unused") Reported-and-tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Acked-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com> Link: https://lore.kernel.org/r/20220104164238.253142-1-hdegoede@redhat.com Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
1 parent 25d2e41 commit aa28514

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

drivers/pinctrl/intel/pinctrl-cherryview.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1471,8 +1471,9 @@ static void chv_gpio_irq_handler(struct irq_desc *desc)
14711471

14721472
offset = cctx->intr_lines[intr_line];
14731473
if (offset == CHV_INVALID_HWIRQ) {
1474-
dev_err(dev, "interrupt on unused interrupt line %u\n", intr_line);
1475-
continue;
1474+
dev_warn_once(dev, "interrupt on unmapped interrupt line %u\n", intr_line);
1475+
/* Some boards expect hwirq 0 to trigger in this case */
1476+
offset = 0;
14761477
}
14771478

14781479
generic_handle_domain_irq(gc->irq.domain, offset);

0 commit comments

Comments
 (0)