ASoC: pxa: fix a memory leak in probe()

Dan Carpenter · broonie · commit aa6464edbd51 · 2023-10-09T13:13:50.000+01:00
Free the "priv" pointer before returning the error code. Fixes: 90eb6b5 ("ASoC: pxa-ssp: add support for an external clock in devicetree") Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Link: https://lore.kernel.org/r/84ac2313-1420-471a-b2cb-3269a2e12a7c@moroto.mountain Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/sound/soc/pxa/pxa-ssp.c b/sound/soc/pxa/pxa-ssp.c
@@ -773,7 +773,7 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
 		if (IS_ERR(priv->extclk)) {
 			ret = PTR_ERR(priv->extclk);
 			if (ret == -EPROBE_DEFER)
-				return ret;
+				goto err_priv;
 
 			priv->extclk = NULL;
 		}

Original file line number	Diff line number	Diff line change
`@@ -773,7 +773,7 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)`
`773`	`773`	`if (IS_ERR(priv->extclk)) {`
`774`	`774`	`ret = PTR_ERR(priv->extclk);`
`775`	`775`	`if (ret == -EPROBE_DEFER)`
`776`		`- return ret;`
	`776`	`+ goto err_priv;`
`777`	`777`
`778`	`778`	`priv->extclk = NULL;`
`779`	`779`	`}`