Skip to content

Commit aa7accb

Browse files
Yang Yingliangvinodkoul
authored andcommitted
dmaengine: at_xdmac: Fix missing unlock in at_xdmac_tasklet()
Add the missing unlock before return from at_xdmac_tasklet(). Fixes: e77e561 ("dmaengine: at_xdmac: Fix race over irq_status") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Tudor Ambarus <tudor.ambarus@microchip.com> Link: https://lore.kernel.org/r/20220107024047.1051915-1-yangyingliang@huawei.com Signed-off-by: Vinod Koul <vkoul@kernel.org>
1 parent 3c62fd3 commit aa7accb

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/dma/at_xdmac.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1681,8 +1681,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t)
16811681
__func__, atchan->irq_status);
16821682

16831683
if (!(atchan->irq_status & AT_XDMAC_CIS_LIS) &&
1684-
!(atchan->irq_status & error_mask))
1684+
!(atchan->irq_status & error_mask)) {
1685+
spin_unlock_irq(&atchan->lock);
16851686
return;
1687+
}
16861688

16871689
if (atchan->irq_status & error_mask)
16881690
at_xdmac_handle_error(atchan);

0 commit comments

Comments
 (0)