Skip to content

Commit ab0e131

Browse files
lweiss-fairphoneandersson
authored andcommitted
clk: qcom: camcc-sm6350: Fix PLL config of PLL2
The 'Agera' PLLs (with clk_agera_pll_configure) do not take some of the parameters that are provided in the vendor driver. Instead the upstream configuration should provide the final user_ctl value that is written to the USER_CTL register. Fix the config so that the PLL is configured correctly, and fixes CAMCC_MCLK* being stuck off. Fixes: 80f5451 ("clk: qcom: Add camera clock controller driver for SM6350") Suggested-by: Taniya Das <taniya.das@oss.qualcomm.com> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Taniya Das <taniya.das@oss.qualcomm.com> Link: https://lore.kernel.org/r/20251021-agera-pll-fixups-v1-1-8c1d8aff4afc@fairphone.com Signed-off-by: Bjorn Andersson <andersson@kernel.org>
1 parent fd0b632 commit ab0e131

1 file changed

Lines changed: 1 addition & 5 deletions

File tree

drivers/clk/qcom/camcc-sm6350.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,15 +145,11 @@ static struct clk_alpha_pll_postdiv camcc_pll1_out_even = {
145145
static const struct alpha_pll_config camcc_pll2_config = {
146146
.l = 0x64,
147147
.alpha = 0x0,
148-
.post_div_val = 0x3 << 8,
149-
.post_div_mask = 0x3 << 8,
150-
.aux_output_mask = BIT(1),
151-
.main_output_mask = BIT(0),
152-
.early_output_mask = BIT(3),
153148
.config_ctl_val = 0x20000800,
154149
.config_ctl_hi_val = 0x400003d2,
155150
.test_ctl_val = 0x04000400,
156151
.test_ctl_hi_val = 0x00004000,
152+
.user_ctl_val = 0x0000030b,
157153
};
158154

159155
static struct clk_alpha_pll camcc_pll2 = {

0 commit comments

Comments
 (0)