Skip to content

Commit ab38253

Browse files
jankaratytso
authored andcommitted
ext4: Update comment in mpage_prepare_extent_to_map()
Since filemap_write_and_wait() is now enough to get journalled data to final location update the comment in mpage_prepare_extent_to_map(). Signed-off-by: Jan Kara <jack@suse.cz> Link: https://lore.kernel.org/r/20230329154950.19720-12-jack@suse.cz Signed-off-by: Theodore Ts'o <tytso@mit.edu>
1 parent 951cafa commit ab38253

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

fs/ext4/inode.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2496,11 +2496,10 @@ static int mpage_prepare_extent_to_map(struct mpage_da_data *mpd)
24962496
* Just submit the page. For data=journal mode we
24972497
* first handle writeout of the page for checkpoint and
24982498
* only after that handle delayed page dirtying. This
2499-
* is crutial so that forcing a transaction commit and
2500-
* then calling filemap_write_and_wait() guarantees
2501-
* current state of data is in its final location. Such
2502-
* sequence is used for example by insert/collapse
2503-
* range operations before discarding the page cache.
2499+
* makes sure current data is checkpointed to the final
2500+
* location before possibly journalling it again which
2501+
* is desirable when the page is frequently dirtied
2502+
* through a pin.
25042503
*/
25052504
if (!mpd->can_map) {
25062505
WARN_ON_ONCE(sb->s_writers.frozen ==

0 commit comments

Comments
 (0)