Skip to content

Commit ab3e004

Browse files
committed
hwmon: (pmbus/core) Request threaded interrupt with IRQF_ONESHOT
0-day rightfully complains: drivers/hwmon/pmbus/pmbus_core.c:3164:7-32: WARNING: Threaded IRQ with no primary handler requested without IRQF_ONESHOT (unless it is nested IRQ) Without IRQF_ONESHOT, the primary interrupt may end up in a loop, and the threaded interrupt handler may never execute. Request interrupt with IRQF_ONESHOT and assume that the interrupt will cleared and re-enabled by clearing the fault condition in the threaded interrupt handler. Reported-by: kernel test robot <lkp@intel.com> Link: https://lore.kernel.org/linux-hwmon/6436efbb.08+e+yEDqvRxvHDP%25lkp@intel.com/T/#u Cc: Patrick Rudolph <patrick.rudolph@9elements.com> Cc: Naresh Solanki <Naresh.Solanki@9elements.com> Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 5dcd53e commit ab3e004

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/hwmon/pmbus/pmbus_core.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3246,8 +3246,8 @@ static int pmbus_irq_setup(struct i2c_client *client, struct pmbus_data *data)
32463246
}
32473247

32483248
/* Register notifiers */
3249-
err = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler, 0,
3250-
"pmbus-irq", data);
3249+
err = devm_request_threaded_irq(dev, client->irq, NULL, pmbus_fault_handler,
3250+
IRQF_ONESHOT, "pmbus-irq", data);
32513251
if (err) {
32523252
dev_err(dev, "failed to request an irq %d\n", err);
32533253
return err;

0 commit comments

Comments
 (0)