bcachefs: Fix return type of dirent_points_to_inode_nowarn()

Kent Overstreet · Kent Overstreet · commit abaa6d4f6ab8 · 2024-10-02T21:30:55.000-04:00
we're returning an error code now, not a bool

Reported-by: Dan Carpenter &lt;dan.carpenter@linaro.org&gt;
Signed-off-by: Kent Overstreet &lt;kent.overstreet@linux.dev&gt;
diff --git a/fs/bcachefs/fsck.c b/fs/bcachefs/fsck.c
@@ -28,8 +28,8 @@ static bool inode_points_to_dirent(struct bch_inode_unpacked *inode,
 		inode->bi_dir_offset	== d.k->p.offset;
 }
 
-static bool dirent_points_to_inode_nowarn(struct bkey_s_c_dirent d,
-				   struct bch_inode_unpacked *inode)
+static int dirent_points_to_inode_nowarn(struct bkey_s_c_dirent d,
+					 struct bch_inode_unpacked *inode)
 {
 	if (d.v->d_type == DT_SUBVOL
 	    ? le32_to_cpu(d.v->d_child_subvol)	== inode->bi_subvol

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@ static bool inode_points_to_dirent(struct bch_inode_unpacked *inode,`
`28`	`28`	`inode->bi_dir_offset == d.k->p.offset;`
`29`	`29`	`}`
`30`	`30`
`31`		`-static bool dirent_points_to_inode_nowarn(struct bkey_s_c_dirent d,`
`32`		`- struct bch_inode_unpacked *inode)`
	`31`	`+static int dirent_points_to_inode_nowarn(struct bkey_s_c_dirent d,`
	`32`	`+ struct bch_inode_unpacked *inode)`
`33`	`33`	`{`
`34`	`34`	`if (d.v->d_type == DT_SUBVOL`
`35`	`35`	`? le32_to_cpu(d.v->d_child_subvol) == inode->bi_subvol`