Skip to content

Commit abe4f5a

Browse files
jwrdegoederafaeljw
authored andcommitted
ACPI: video: Remove desktops without backlight DMI quirks
After the recent backlight changes acpi_video# backlight devices are only registered when explicitly requested from the cmdline, by DMI quirk or by the GPU driver. This means that we no longer get false-positive backlight control support advertised on desktop boards. Remove the 3 DMI quirks for desktop boards where the false-positive issue was fixed through quirks before. Note many more desktop boards were affected but we never build a full quirk list for this. Reviewed-by: Mario Limonciello <mario.limonciello@amd.com> Signed-off-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 67abe9c commit abe4f5a

1 file changed

Lines changed: 0 additions & 35 deletions

File tree

drivers/acpi/video_detect.c

Lines changed: 0 additions & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -130,12 +130,6 @@ static int video_detect_force_native(const struct dmi_system_id *d)
130130
return 0;
131131
}
132132

133-
static int video_detect_force_none(const struct dmi_system_id *d)
134-
{
135-
acpi_backlight_dmi = acpi_backlight_none;
136-
return 0;
137-
}
138-
139133
static const struct dmi_system_id video_detect_dmi_table[] = {
140134
/*
141135
* Models which should use the vendor backlight interface,
@@ -768,35 +762,6 @@ static const struct dmi_system_id video_detect_dmi_table[] = {
768762
DMI_MATCH(DMI_PRODUCT_NAME, "Vostro 15 3535"),
769763
},
770764
},
771-
772-
/*
773-
* Desktops which falsely report a backlight and which our heuristics
774-
* for this do not catch.
775-
*/
776-
{
777-
.callback = video_detect_force_none,
778-
/* Dell OptiPlex 9020M */
779-
.matches = {
780-
DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
781-
DMI_MATCH(DMI_PRODUCT_NAME, "OptiPlex 9020M"),
782-
},
783-
},
784-
{
785-
.callback = video_detect_force_none,
786-
/* GIGABYTE GB-BXBT-2807 */
787-
.matches = {
788-
DMI_MATCH(DMI_SYS_VENDOR, "GIGABYTE"),
789-
DMI_MATCH(DMI_PRODUCT_NAME, "GB-BXBT-2807"),
790-
},
791-
},
792-
{
793-
.callback = video_detect_force_none,
794-
/* MSI MS-7721 */
795-
.matches = {
796-
DMI_MATCH(DMI_SYS_VENDOR, "MSI"),
797-
DMI_MATCH(DMI_PRODUCT_NAME, "MS-7721"),
798-
},
799-
},
800765
{ },
801766
};
802767

0 commit comments

Comments
 (0)