Skip to content

Commit ac1d977

Browse files
Nirjhar-Roy-0211cmaiolino
authored andcommitted
xfs: Add a comment in xfs_log_sb()
Add a comment explaining why the sb_frextents are updated outside the if (xfs_has_lazycount(mp) check even though it is a lazycounter. RT groups are supported only in v5 filesystems which always have lazycounter enabled - so putting it inside the if(xfs_has_lazycount(mp) check is redundant. Suggested-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Darrick J. Wong <djwong@kernel.org> Reviewed-by: Christoph Hellwig <hch@lst.de> Signed-off-by: Nirjhar Roy (IBM) <nirjhar.roy.lists@gmail.com> Signed-off-by: Carlos Maiolino <cem@kernel.org>
1 parent 8baa9bc commit ac1d977

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

fs/xfs/libxfs/xfs_sb.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1347,6 +1347,9 @@ xfs_log_sb(
13471347
* feature was introduced. This counter can go negative due to the way
13481348
* we handle nearly-lockless reservations, so we must use the _positive
13491349
* variant here to avoid writing out nonsense frextents.
1350+
*
1351+
* RT groups are only supported on v5 file systems, which always
1352+
* have lazy SB counters.
13501353
*/
13511354
if (xfs_has_rtgroups(mp) && !xfs_has_zoned(mp)) {
13521355
mp->m_sb.sb_frextents =

0 commit comments

Comments
 (0)