Skip to content

Commit ac59a47

Browse files
committed
livepatch: Remove duplicate warning about missing reliable stacktrace support
WARN_ON_ONCE() could not be called safely under rq lock because of console deadlock issues. Moreover WARN_ON_ONCE() is superfluous in klp_check_stack(), because stack_trace_save_tsk_reliable() cannot return -ENOSYS thanks to klp_have_reliable_stack() check in klp_try_switch_task(). [ mbenes: changelog edited ] Signed-off-by: Miroslav Benes <mbenes@suse.cz> Acked-by: Josh Poimboeuf <jpoimboe@redhat.com> Reviewed-by: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> Signed-off-by: Petr Mladek <pmladek@suse.com>
1 parent 67059d6 commit ac59a47

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

kernel/livepatch/transition.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,6 @@ static int klp_check_stack(struct task_struct *task, char *err_buf)
259259
int ret, nr_entries;
260260

261261
ret = stack_trace_save_tsk_reliable(task, entries, ARRAY_SIZE(entries));
262-
WARN_ON_ONCE(ret == -ENOSYS);
263262
if (ret < 0) {
264263
snprintf(err_buf, STACK_ERR_BUF_SIZE,
265264
"%s: %s:%d has an unreliable stack\n",

0 commit comments

Comments
 (0)