Skip to content

Commit ac8db4c

Browse files
hkallweitsuperna9999
authored andcommitted
arm64: dts: meson-g12-common: Make mmc host controller interrupts level-sensitive
The usage of edge-triggered interrupts lead to lost interrupts under load, see [0]. This was confirmed to be fixed by using level-triggered interrupts. The report was about SDIO. However, as the host controller is the same for SD and MMC, apply the change to all mmc controller instances. [0] https://www.spinics.net/lists/linux-mmc/msg73991.html Fixes: 4759fd8 ("arm64: dts: meson: g12a: add mmc nodes") Tested-by: FUKAUMI Naoki <naoki@radxa.com> Tested-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Tested-by: Jerome Brunet <jbrunet@baylibre.com> Cc: stable@vger.kernel.org Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com> Acked-by: Neil Armstrong <neil.armstrong@linaro.org> Link: https://lore.kernel.org/r/27d89baa-b8fa-baca-541b-ef17a97cde3c@gmail.com Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
1 parent d182bcf commit ac8db4c

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2324,7 +2324,7 @@
23242324
sd_emmc_a: sd@ffe03000 {
23252325
compatible = "amlogic,meson-axg-mmc";
23262326
reg = <0x0 0xffe03000 0x0 0x800>;
2327-
interrupts = <GIC_SPI 189 IRQ_TYPE_EDGE_RISING>;
2327+
interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
23282328
status = "disabled";
23292329
clocks = <&clkc CLKID_SD_EMMC_A>,
23302330
<&clkc CLKID_SD_EMMC_A_CLK0>,
@@ -2336,7 +2336,7 @@
23362336
sd_emmc_b: sd@ffe05000 {
23372337
compatible = "amlogic,meson-axg-mmc";
23382338
reg = <0x0 0xffe05000 0x0 0x800>;
2339-
interrupts = <GIC_SPI 190 IRQ_TYPE_EDGE_RISING>;
2339+
interrupts = <GIC_SPI 190 IRQ_TYPE_LEVEL_HIGH>;
23402340
status = "disabled";
23412341
clocks = <&clkc CLKID_SD_EMMC_B>,
23422342
<&clkc CLKID_SD_EMMC_B_CLK0>,
@@ -2348,7 +2348,7 @@
23482348
sd_emmc_c: mmc@ffe07000 {
23492349
compatible = "amlogic,meson-axg-mmc";
23502350
reg = <0x0 0xffe07000 0x0 0x800>;
2351-
interrupts = <GIC_SPI 191 IRQ_TYPE_EDGE_RISING>;
2351+
interrupts = <GIC_SPI 191 IRQ_TYPE_LEVEL_HIGH>;
23522352
status = "disabled";
23532353
clocks = <&clkc CLKID_SD_EMMC_C>,
23542354
<&clkc CLKID_SD_EMMC_C_CLK0>,

0 commit comments

Comments
 (0)