Skip to content

Commit ac9dc1b

Browse files
committed
drm/exynos: Use regular fbdev I/O helpers
Use the regular fbdev helpers for framebuffer I/O instead of DRM's helpers. Exynos does not use damage handling, so DRM's fbdev helpers are mere wrappers around the fbdev code. By using fbdev helpers directly within each DRM fbdev emulation, we can eventually remove DRM's wrapper functions entirely. v4: * use initializer macros for struct fb_ops v3: * don't reorder Makefile rules (Sam) v2: * use FB_IO_HELPERS option Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de> Acked-by: Sam Ravnborg <sam@ravnborg.org> Cc: Inki Dae <inki.dae@samsung.com> Cc: Seung-Woo Kim <sw0312.kim@samsung.com> Cc: Kyungmin Park <kyungmin.park@samsung.com> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Cc: Alim Akhtar <alim.akhtar@samsung.com> Link: https://patchwork.freedesktop.org/patch/msgid/20230530151228.22979-5-tzimmermann@suse.de
1 parent eb958c9 commit ac9dc1b

2 files changed

Lines changed: 5 additions & 5 deletions

File tree

drivers/gpu/drm/exynos/Kconfig

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ config DRM_EXYNOS
77
select DRM_DISPLAY_HELPER if DRM_EXYNOS_DP
88
select DRM_KMS_HELPER
99
select VIDEOMODE_HELPERS
10+
select FB_IO_HELPERS if DRM_FBDEV_EMULATION
1011
select SND_SOC_HDMI_CODEC if SND_SOC
1112
help
1213
Choose this option if you have a Samsung SoC Exynos chipset.

drivers/gpu/drm/exynos/exynos_drm_fbdev.c

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,8 @@
88
* Seung-Woo Kim <sw0312.kim@samsung.com>
99
*/
1010

11+
#include <linux/fb.h>
12+
1113
#include <drm/drm_crtc_helper.h>
1214
#include <drm/drm_drv.h>
1315
#include <drm/drm_fb_helper.h>
@@ -47,13 +49,10 @@ static void exynos_drm_fb_destroy(struct fb_info *info)
4749

4850
static const struct fb_ops exynos_drm_fb_ops = {
4951
.owner = THIS_MODULE,
52+
__FB_DEFAULT_IO_OPS_RDWR,
5053
DRM_FB_HELPER_DEFAULT_OPS,
54+
__FB_DEFAULT_IO_OPS_DRAW,
5155
.fb_mmap = exynos_drm_fb_mmap,
52-
.fb_read = drm_fb_helper_cfb_read,
53-
.fb_write = drm_fb_helper_cfb_write,
54-
.fb_fillrect = drm_fb_helper_cfb_fillrect,
55-
.fb_copyarea = drm_fb_helper_cfb_copyarea,
56-
.fb_imageblit = drm_fb_helper_cfb_imageblit,
5756
.fb_destroy = exynos_drm_fb_destroy,
5857
};
5958

0 commit comments

Comments
 (0)