Skip to content

Commit ac9fb7d

Browse files
committed
parisc: drivers: Fix kdoc warnings
Signed-off-by: Helge Deller <deller@gmx.de>
1 parent 7d653ad commit ac9fb7d

1 file changed

Lines changed: 17 additions & 16 deletions

File tree

arch/parisc/kernel/drivers.c

Lines changed: 17 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
*
55
* Copyright (c) 1999 The Puffin Group
66
* Copyright (c) 2001 Matthew Wilcox for Hewlett Packard
7-
* Copyright (c) 2001 Helge Deller <deller@gmx.de>
7+
* Copyright (c) 2001-2023 Helge Deller <deller@gmx.de>
88
* Copyright (c) 2001,2002 Ryan Bradetich
99
* Copyright (c) 2004-2005 Thibaut VARENE <varenet@parisc-linux.org>
1010
*
@@ -74,13 +74,13 @@ static int descend_children(struct device * dev, void * data)
7474
}
7575

7676
/**
77-
* for_each_padev - Iterate over all devices in the tree
78-
* @fn: Function to call for each device.
79-
* @data: Data to pass to the called function.
77+
* for_each_padev - Iterate over all devices in the tree
78+
* @fn: Function to call for each device.
79+
* @data: Data to pass to the called function.
8080
*
81-
* This performs a depth-first traversal of the tree, calling the
82-
* function passed for each node. It calls the function for parents
83-
* before children.
81+
* This performs a depth-first traversal of the tree, calling the
82+
* function passed for each node. It calls the function for parents
83+
* before children.
8484
*/
8585

8686
static int for_each_padev(int (*fn)(struct device *, void *), void * data)
@@ -280,7 +280,7 @@ int __init machine_has_merced_bus(void)
280280

281281
/**
282282
* find_pa_parent_type - Find a parent of a specific type
283-
* @dev: The device to start searching from
283+
* @padev: The device to start searching from
284284
* @type: The device type to search for.
285285
*
286286
* Walks up the device tree looking for a device of the specified type.
@@ -344,8 +344,8 @@ static char *print_hwpath(struct hardware_path *path, char *output)
344344

345345
/**
346346
* print_pa_hwpath - Returns hardware path for PA devices
347-
* dev: The device to return the path for
348-
* output: Pointer to a previously-allocated array to place the path in.
347+
* @dev: The device to return the path for
348+
* @output: Pointer to a previously-allocated array to place the path in.
349349
*
350350
* This function fills in the output array with a human-readable path
351351
* to a PA device. This string is compatible with that used by PDC, and
@@ -379,8 +379,8 @@ EXPORT_SYMBOL(get_pci_node_path);
379379

380380
/**
381381
* print_pci_hwpath - Returns hardware path for PCI devices
382-
* dev: The device to return the path for
383-
* output: Pointer to a previously-allocated array to place the path in.
382+
* @dev: The device to return the path for
383+
* @output: Pointer to a previously-allocated array to place the path in.
384384
*
385385
* This function fills in the output array with a human-readable path
386386
* to a PCI device. This string is compatible with that used by PDC, and
@@ -415,7 +415,8 @@ static void setup_bus_id(struct parisc_device *padev)
415415
dev_set_name(&padev->dev, name);
416416
}
417417

418-
struct parisc_device * __init create_tree_node(char id, struct device *parent)
418+
static struct parisc_device * __init create_tree_node(char id,
419+
struct device *parent)
419420
{
420421
struct parisc_device *dev = kzalloc(sizeof(*dev), GFP_KERNEL);
421422
if (!dev)
@@ -741,7 +742,7 @@ parse_tree_node(struct device *parent, int index, struct hardware_path *modpath)
741742
};
742743

743744
if (device_for_each_child(parent, &recurse_data, descend_children))
744-
/* nothing */;
745+
{ /* nothing */ };
745746

746747
return d.dev;
747748
}
@@ -771,8 +772,8 @@ EXPORT_SYMBOL(hwpath_to_device);
771772

772773
/**
773774
* device_to_hwpath - Populates the hwpath corresponding to the given device.
774-
* @param dev the target device
775-
* @param path pointer to a previously allocated hwpath struct to be filled in
775+
* @dev: the target device
776+
* @path: pointer to a previously allocated hwpath struct to be filled in
776777
*/
777778
void device_to_hwpath(struct device *dev, struct hardware_path *path)
778779
{

0 commit comments

Comments
 (0)