Skip to content

Commit ace8f1c

Browse files
paulmenzelrafaeljw
authored andcommitted
ACPICA: executer/exsystem: Inform users about ACPI spec violation
ACPICA commit 05ba545ce7859392250b18c10081db25c90ed8d7 Values greater than 100 microseconds violate the ACPI specification, so warn users about it. From ACPI Specification version 6.2 Errata A, 19.6.128 *Stall (Stall for a Short Time)*: > The implementation of Stall is OS-specific, but must not relinquish > control of the processor. Because of this, delays longer than 100 > microseconds must use Sleep instead of Stall. Link: acpica/acpica@05ba545c Signed-off-by: Bob Moore <robert.moore@intel.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Reported-by: kernel test robot <lkp@intel.com>
1 parent 1c5d62f commit ace8f1c

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

drivers/acpi/acpica/exsystem.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,11 @@ acpi_status acpi_ex_system_do_stall(u32 how_long_us)
137137
"Time parameter is too large (%u)", how_long_us));
138138
status = AE_AML_OPERAND_VALUE;
139139
} else {
140+
if (how_long_US > 100) {
141+
ACPI_WARNING((AE_INFO,
142+
"Time parameter %u us > 100 us violating ACPI spec, please fix the firmware.",
143+
how_long_us));
144+
}
140145
acpi_os_stall(how_long_us);
141146
}
142147

0 commit comments

Comments
 (0)