Skip to content

Commit ad36aab

Browse files
Yu Zhangsean-jc
authored andcommitted
KVM: nVMX: Remove outdated comments in nested_vmx_setup_ctls_msrs()
nested_vmx_setup_ctls_msrs() initializes the vmcs_conf.nested, which stores the global VMX MSR configurations when nested is supported, regardless of any particular CPUID settings for one VM. Commit 6defc59 ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS") added the some feature flags for secondary proc-based controls, so that those features can be available in KVM_GET_MSRS. Yet this commit did not remove the obsolete comments in nested_vmx_setup_ctls_msrs(). Just fix the comments, and no functional change intended. Fixes: 6defc59 ("KVM: nVMX: include conditional controls in /dev/kvm KVM_GET_MSRS") Signed-off-by: Yu Zhang <yu.c.zhang@linux.intel.com> Link: https://lore.kernel.org/r/20230119141946.585610-1-yu.c.zhang@linux.intel.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent d8708b8 commit ad36aab

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

arch/x86/kvm/vmx/nested.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -6866,11 +6866,6 @@ void nested_vmx_setup_ctls_msrs(struct vmcs_config *vmcs_conf, u32 ept_caps)
68666866
msrs->procbased_ctls_low &=
68676867
~(CPU_BASED_CR3_LOAD_EXITING | CPU_BASED_CR3_STORE_EXITING);
68686868

6869-
/*
6870-
* secondary cpu-based controls. Do not include those that
6871-
* depend on CPUID bits, they are added later by
6872-
* vmx_vcpu_after_set_cpuid.
6873-
*/
68746869
msrs->secondary_ctls_low = 0;
68756870

68766871
msrs->secondary_ctls_high = vmcs_conf->cpu_based_2nd_exec_ctrl;

0 commit comments

Comments
 (0)