Skip to content

Commit ad5042e

Browse files
YongWu-HFjoergroedel
authored andcommitted
iommu/mediatek: Remove the power status checking in tlb flush all
To simplify the code, Remove the power status checking in the tlb_flush_all, remove this: if (pm_runtime_get_if_in_use(data->dev) <= 0) continue; The mtk_iommu_tlb_flush_all is called from a) isr b) tlb flush range fail case c) iommu_create_device_direct_mappings In first two cases, the power and clock are always enabled. In the third case tlb flush is unnecessary because in a later patch in the series a full flush from the pm_runtime_resume callback is added. In addition, writing the tlb control register when the iommu is not resumed is ok and the write is ignored. Signed-off-by: Yong Wu <yong.wu@mediatek.com> [refactor commit log] Signed-off-by: Dafna Hirschfeld <dafna.hirschfeld@collabora.com> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> Link: https://lore.kernel.org/r/20211208120744.2415-4-dafna.hirschfeld@collabora.com Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 4ea7944 commit ad5042e

1 file changed

Lines changed: 0 additions & 5 deletions

File tree

drivers/iommu/mtk_iommu.c

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -210,15 +210,10 @@ static struct mtk_iommu_domain *to_mtk_domain(struct iommu_domain *dom)
210210

211211
static void mtk_iommu_tlb_flush_all(struct mtk_iommu_data *data)
212212
{
213-
if (pm_runtime_get_if_in_use(data->dev) <= 0)
214-
return;
215-
216213
writel_relaxed(F_INVLD_EN1 | F_INVLD_EN0,
217214
data->base + data->plat_data->inv_sel_reg);
218215
writel_relaxed(F_ALL_INVLD, data->base + REG_MMU_INVALIDATE);
219216
wmb(); /* Make sure the tlb flush all done */
220-
221-
pm_runtime_put(data->dev);
222217
}
223218

224219
static void mtk_iommu_tlb_flush_range_sync(unsigned long iova, size_t size,

0 commit comments

Comments
 (0)