media: nxp: imx-jpeg: use goto instead of return

Hans Verkuil · Hans Verkuil · commit ada092e80c10 · 2023-10-13T11:33:22.000+02:00
For consistency use goto instead of return.

This fixes a smatch warning:

drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c:2792 mxc_jpeg_probe() warn: missing unwind goto?

Signed-off-by: Hans Verkuil &lt;hverkuil-cisco@xs4all.nl&gt;
diff --git a/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c b/drivers/media/platform/nxp/imx-jpeg/mxc-jpeg.c
@@ -2789,7 +2789,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)
 	ret = mxc_jpeg_attach_pm_domains(jpeg);
 	if (ret < 0) {
 		dev_err(dev, "failed to attach power domains %d\n", ret);
-		return ret;
+		goto err_clk;
 	}
 
 	/* v4l2 */

Original file line number	Diff line number	Diff line change
`@@ -2789,7 +2789,7 @@ static int mxc_jpeg_probe(struct platform_device *pdev)`
`2789`	`2789`	`ret = mxc_jpeg_attach_pm_domains(jpeg);`
`2790`	`2790`	`if (ret < 0) {`
`2791`	`2791`	`dev_err(dev, "failed to attach power domains %d\n", ret);`
`2792`		`- return ret;`
	`2792`	`+ goto err_clk;`
`2793`	`2793`	`}`
`2794`	`2794`
`2795`	`2795`	`/* v4l2 */`