Skip to content

Commit ae089de

Browse files
Bartosz GolaszewskipH5
authored andcommitted
reset: gpio: check the return value of gpiod_set_value_cansleep()
gpiod_set_value_cansleep() now returns an integer and can indicate failures. Propagate the return value to the caller of the reset API. Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@oss.qualcomm.com> Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
1 parent 5aac7af commit ae089de

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

drivers/reset/reset-gpio.c

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -22,19 +22,15 @@ static int reset_gpio_assert(struct reset_controller_dev *rc, unsigned long id)
2222
{
2323
struct reset_gpio_priv *priv = rc_to_reset_gpio(rc);
2424

25-
gpiod_set_value_cansleep(priv->reset, 1);
26-
27-
return 0;
25+
return gpiod_set_value_cansleep(priv->reset, 1);
2826
}
2927

3028
static int reset_gpio_deassert(struct reset_controller_dev *rc,
3129
unsigned long id)
3230
{
3331
struct reset_gpio_priv *priv = rc_to_reset_gpio(rc);
3432

35-
gpiod_set_value_cansleep(priv->reset, 0);
36-
37-
return 0;
33+
return gpiod_set_value_cansleep(priv->reset, 0);
3834
}
3935

4036
static int reset_gpio_status(struct reset_controller_dev *rc, unsigned long id)

0 commit comments

Comments
 (0)