Skip to content

Commit ae93d8e

Browse files
Dan Carpentermstsirkin
authored andcommitted
virtio_ring: Cut and paste bugs in vring_create_virtqueue_packed()
There is a copy and paste bug in the error handling of this code and it uses "ring_dma_addr" three times instead of "device_event_dma_addr" and "driver_event_dma_addr". Fixes: 1ce9e60 (" virtio_ring: introduce packed ring support") Reported-by: Robert Buhren <robert.buhren@sect.tu-berlin.de> Reported-by: Felicitas Hetzelt <file@sect.tu-berlin.de> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Link: https://lore.kernel.org/r/X8pGRJlEzyn+04u2@mwanda Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Jason Wang <jasowang@redhat.com>
1 parent 1a5514c commit ae93d8e

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/virtio/virtio_ring.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1676,9 +1676,9 @@ static struct virtqueue *vring_create_virtqueue_packed(
16761676
err_desc_state:
16771677
kfree(vq);
16781678
err_vq:
1679-
vring_free_queue(vdev, event_size_in_bytes, device, ring_dma_addr);
1679+
vring_free_queue(vdev, event_size_in_bytes, device, device_event_dma_addr);
16801680
err_device:
1681-
vring_free_queue(vdev, event_size_in_bytes, driver, ring_dma_addr);
1681+
vring_free_queue(vdev, event_size_in_bytes, driver, driver_event_dma_addr);
16821682
err_driver:
16831683
vring_free_queue(vdev, ring_size_in_bytes, ring, ring_dma_addr);
16841684
err_ring:

0 commit comments

Comments
 (0)