Skip to content

Commit ae9c480

Browse files
m-weigandlag-linaro
authored andcommitted
backlight: lm3630a: Turn off both led strings when display is blank
Use backlight_is_blank() to determine if the led strings should be turned off in the update_status() functions of both strings. Signed-off-by: Maximilian Weigand <mweigand@mweigand.net> Reviewed-by: Daniel Thompson <daniel.thompson@linaro.org> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Link: https://lore.kernel.org/r/20230510085239.1253896-1-mweigand2017@gmail.com Signed-off-by: Lee Jones <lee@kernel.org>
1 parent 77036e0 commit ae9c480

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

drivers/video/backlight/lm3630a_bl.c

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -202,7 +202,9 @@ static int lm3630a_bank_a_update_status(struct backlight_device *bl)
202202
usleep_range(1000, 2000);
203203
/* minimum brightness is 0x04 */
204204
ret = lm3630a_write(pchip, REG_BRT_A, bl->props.brightness);
205-
if (bl->props.brightness < 0x4)
205+
206+
if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
207+
/* turn the string off */
206208
ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDA_ENABLE, 0);
207209
else
208210
ret |= lm3630a_update(pchip, REG_CTRL,
@@ -277,7 +279,9 @@ static int lm3630a_bank_b_update_status(struct backlight_device *bl)
277279
usleep_range(1000, 2000);
278280
/* minimum brightness is 0x04 */
279281
ret = lm3630a_write(pchip, REG_BRT_B, bl->props.brightness);
280-
if (bl->props.brightness < 0x4)
282+
283+
if (backlight_is_blank(bl) || (backlight_get_brightness(bl) < 0x4))
284+
/* turn the string off */
281285
ret |= lm3630a_update(pchip, REG_CTRL, LM3630A_LEDB_ENABLE, 0);
282286
else
283287
ret |= lm3630a_update(pchip, REG_CTRL,

0 commit comments

Comments
 (0)