Skip to content

Commit aeca632

Browse files
committed
trace: avoid pointless cred reference count bump
The creds are allocated via prepare_creds() which has already taken a reference. Link: https://lore.kernel.org/r/20241125-work-cred-v2-25-68b9d38bb5b2@kernel.org Reviewed-by: Jeff Layton <jlayton@kernel.org> Reviewed-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 34ab26f commit aeca632

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

kernel/trace/trace_events_user.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1469,14 +1469,14 @@ static int user_event_set_call_visible(struct user_event *user, bool visible)
14691469
*/
14701470
cred->fsuid = GLOBAL_ROOT_UID;
14711471

1472-
old_cred = override_creds(get_new_cred(cred));
1472+
old_cred = override_creds(cred);
14731473

14741474
if (visible)
14751475
ret = trace_add_event_call(&user->call);
14761476
else
14771477
ret = trace_remove_event_call(&user->call);
14781478

1479-
put_cred(revert_creds(old_cred));
1479+
revert_creds(old_cred);
14801480
put_cred(cred);
14811481

14821482
return ret;

0 commit comments

Comments
 (0)