Skip to content

Commit aee17df

Browse files
keesgregkh
authored andcommitted
staging: rtl8192e: Annotate struct rtllib_txb with __counted_by
Prepare for the coming implementation by GCC and Clang of the __counted_by attribute. Flexible array members annotated with __counted_by can have their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS (for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family functions). As found with Coccinelle[1], add __counted_by for struct rtllib_txb. [1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Cc: Philipp Hortmann <philipp.g.hortmann@gmail.com> Cc: linux-staging@lists.linux.dev Signed-off-by: Kees Cook <keescook@chromium.org> Reviewed-by: "Gustavo A. R. Silva" <gustavoars@kernel.org> Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com> Link: https://lore.kernel.org/r/20230817204523.never.034-kees@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent f6f0d97 commit aee17df

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/staging/rtl8192e/rtllib.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -814,7 +814,7 @@ struct rtllib_txb {
814814
u16 reserved;
815815
__le16 frag_size;
816816
__le16 payload_size;
817-
struct sk_buff *fragments[];
817+
struct sk_buff *fragments[] __counted_by(nr_frags);
818818
};
819819

820820
#define MAX_SUBFRAME_COUNT 64

0 commit comments

Comments
 (0)