Skip to content

Commit af3973e

Browse files
Thomas-fouriermartinkpetersen
authored andcommitted
scsi: snic: Remove unused linkstatus
The (struct vnic_dev).linkstatus buffer is freed in svnic_dev_unregister() and referenced in svnic_dev_link_status() but never alloc'd. This means (struct vnic_dev).linkstatus is always null and the dealloc the reference in svnic_dev_link_status() is dead code. Signed-off-by: Thomas Fourier <fourier.thomas@gmail.com> Acked-by: Karan Tilak Kumar <kartilak@cisco.com> Link: https://patch.msgid.link/20260216141056.59429-2-fourier.thomas@gmail.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 38353c2 commit af3973e

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

drivers/scsi/snic/vnic_dev.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,6 @@ struct vnic_dev {
4242
struct vnic_devcmd_notify *notify;
4343
struct vnic_devcmd_notify notify_copy;
4444
dma_addr_t notify_pa;
45-
u32 *linkstatus;
46-
dma_addr_t linkstatus_pa;
4745
struct vnic_stats *stats;
4846
dma_addr_t stats_pa;
4947
struct vnic_devcmd_fw_info *fw_info;
@@ -650,8 +648,6 @@ int svnic_dev_init(struct vnic_dev *vdev, int arg)
650648

651649
int svnic_dev_link_status(struct vnic_dev *vdev)
652650
{
653-
if (vdev->linkstatus)
654-
return *vdev->linkstatus;
655651

656652
if (!vnic_dev_notify_ready(vdev))
657653
return 0;
@@ -686,11 +682,6 @@ void svnic_dev_unregister(struct vnic_dev *vdev)
686682
sizeof(struct vnic_devcmd_notify),
687683
vdev->notify,
688684
vdev->notify_pa);
689-
if (vdev->linkstatus)
690-
dma_free_coherent(&vdev->pdev->dev,
691-
sizeof(u32),
692-
vdev->linkstatus,
693-
vdev->linkstatus_pa);
694685
if (vdev->stats)
695686
dma_free_coherent(&vdev->pdev->dev,
696687
sizeof(struct vnic_stats),

0 commit comments

Comments
 (0)