Skip to content

Commit afc1988

Browse files
krzkgclement
authored andcommitted
ARM: dts: marvell: dove: drop incorrect reg in fixed regulators
Fixed regulators are not in some bus and bindings do not allow a "reg" property. Move them out of "regulators" node to top-level. dove-cubox.dtb: regulator@1: Unevaluated properties are not allowed ('reg' was unexpected) Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Gregory CLEMENT <gregory.clement@bootlin.com>
1 parent afa6b4f commit afc1988

4 files changed

Lines changed: 42 additions & 64 deletions

File tree

arch/arm/boot/dts/marvell/dove-cm-a510.dtsi

Lines changed: 6 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -108,18 +108,12 @@
108108
};
109109
};
110110

111-
regulators {
112-
compatible = "simple-bus";
113-
#address-cells = <1>;
114-
#size-cells = <0>;
115-
116-
wifi_power: regulator@1 {
117-
compatible = "regulator-fixed";
118-
regulator-name = "WiFi Power";
119-
regulator-min-microvolt = <3300000>;
120-
regulator-max-microvolt = <3300000>;
121-
gpio = <&gpio2 7 GPIO_ACTIVE_HIGH>;
122-
};
111+
wifi_power: regulator-1 {
112+
compatible = "regulator-fixed";
113+
regulator-name = "WiFi Power";
114+
regulator-min-microvolt = <3300000>;
115+
regulator-max-microvolt = <3300000>;
116+
gpio = <&gpio2 7 GPIO_ACTIVE_HIGH>;
123117
};
124118
};
125119

arch/arm/boot/dts/marvell/dove-cubox.dts

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -28,24 +28,17 @@
2828
};
2929
};
3030

31-
regulators {
32-
compatible = "simple-bus";
33-
#address-cells = <1>;
34-
#size-cells = <0>;
35-
36-
usb_power: regulator@1 {
37-
compatible = "regulator-fixed";
38-
reg = <1>;
39-
regulator-name = "USB Power";
40-
regulator-min-microvolt = <5000000>;
41-
regulator-max-microvolt = <5000000>;
42-
enable-active-high;
43-
regulator-always-on;
44-
regulator-boot-on;
45-
gpio = <&gpio0 1 0>;
46-
pinctrl-0 = <&pmx_gpio_1>;
47-
pinctrl-names = "default";
48-
};
31+
usb_power: regulator-1 {
32+
compatible = "regulator-fixed";
33+
regulator-name = "USB Power";
34+
regulator-min-microvolt = <5000000>;
35+
regulator-max-microvolt = <5000000>;
36+
enable-active-high;
37+
regulator-always-on;
38+
regulator-boot-on;
39+
gpio = <&gpio0 1 0>;
40+
pinctrl-0 = <&pmx_gpio_1>;
41+
pinctrl-names = "default";
4942
};
5043

5144
clocks {

arch/arm/boot/dts/marvell/dove-d3plug.dts

Lines changed: 11 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -37,24 +37,17 @@
3737
};
3838
};
3939

40-
regulators {
41-
compatible = "simple-bus";
42-
#address-cells = <1>;
43-
#size-cells = <0>;
44-
45-
usb_power: regulator@1 {
46-
compatible = "regulator-fixed";
47-
reg = <1>;
48-
regulator-name = "USB Power";
49-
regulator-min-microvolt = <5000000>;
50-
regulator-max-microvolt = <5000000>;
51-
enable-active-high;
52-
regulator-always-on;
53-
regulator-boot-on;
54-
gpio = <&gpio0 8 0>;
55-
pinctrl-0 = <&pmx_gpio_8>;
56-
pinctrl-names = "default";
57-
};
40+
usb_power: regulator-1 {
41+
compatible = "regulator-fixed";
42+
regulator-name = "USB Power";
43+
regulator-min-microvolt = <5000000>;
44+
regulator-max-microvolt = <5000000>;
45+
enable-active-high;
46+
regulator-always-on;
47+
regulator-boot-on;
48+
gpio = <&gpio0 8 0>;
49+
pinctrl-0 = <&pmx_gpio_8>;
50+
pinctrl-names = "default";
5851
};
5952
};
6053

arch/arm/boot/dts/marvell/dove-sbc-a510.dts

Lines changed: 14 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -76,22 +76,20 @@
7676
stdout-path = &uart0;
7777
};
7878

79-
regulators {
80-
usb0_power: regulator@2 {
81-
compatible = "regulator-fixed";
82-
regulator-name = "USB Power";
83-
regulator-min-microvolt = <5000000>;
84-
regulator-max-microvolt = <5000000>;
85-
gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
86-
};
87-
88-
mmc_power: regulator@3 {
89-
compatible = "regulator-fixed";
90-
regulator-name = "MMC Power";
91-
regulator-min-microvolt = <3300000>;
92-
regulator-max-microvolt = <3300000>;
93-
gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
94-
};
79+
usb0_power: regulator-2 {
80+
compatible = "regulator-fixed";
81+
regulator-name = "USB Power";
82+
regulator-min-microvolt = <5000000>;
83+
regulator-max-microvolt = <5000000>;
84+
gpio = <&gpio_ext 0 GPIO_ACTIVE_HIGH>;
85+
};
86+
87+
mmc_power: regulator-3 {
88+
compatible = "regulator-fixed";
89+
regulator-name = "MMC Power";
90+
regulator-min-microvolt = <3300000>;
91+
regulator-max-microvolt = <3300000>;
92+
gpio = <&gpio_ext 13 GPIO_ACTIVE_HIGH>;
9593
};
9694
};
9795

0 commit comments

Comments
 (0)