Skip to content

Commit afca9e1

Browse files
fenghusthujoergroedel
authored andcommitted
iommu/vt-d: Fix PCI device refcount leak in has_external_pci()
for_each_pci_dev() is implemented by pci_get_device(). The comment of pci_get_device() says that it will increase the reference count for the returned pci_dev and also decrease the reference count for the input pci_dev @from if it is not NULL. If we break for_each_pci_dev() loop with pdev not NULL, we need to call pci_dev_put() to decrease the reference count. Add the missing pci_dev_put() before 'return true' to avoid reference count leak. Fixes: 89a6079 ("iommu/vt-d: Force IOMMU on for platform opt in hint") Signed-off-by: Xiongfeng Wang <wangxiongfeng2@huawei.com> Link: https://lore.kernel.org/r/20221121113649.190393-2-wangxiongfeng2@huawei.com Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com> Signed-off-by: Joerg Roedel <jroedel@suse.de>
1 parent 6927d35 commit afca9e1

1 file changed

Lines changed: 3 additions & 1 deletion

File tree

drivers/iommu/intel/iommu.c

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3873,8 +3873,10 @@ static inline bool has_external_pci(void)
38733873
struct pci_dev *pdev = NULL;
38743874

38753875
for_each_pci_dev(pdev)
3876-
if (pdev->external_facing)
3876+
if (pdev->external_facing) {
3877+
pci_dev_put(pdev);
38773878
return true;
3879+
}
38783880

38793881
return false;
38803882
}

0 commit comments

Comments
 (0)