Skip to content

Commit b0b6a8d

Browse files
committed
KVM: x86/pmu: Elide WRMSRs when loading guest PMCs if values already match
When loading a mediated PMU state, elide the WRMSRs to load PMCs with the guest's value if the value in hardware already matches the guest's value. For the relatively common case where neither the guest nor the host is actively using the PMU, i.e. when all/many counters are '0', eliding the WRMSRs reduces the latency of handling VM-Exit by a measurable amount (WRMSR is significantly more expensive than RDPMC). As measured by KVM-Unit-Tests' CPUID VM-Exit testcase, this provides a a ~25% reduction in latency (4k => 3k cycles) on Intel Emerald Rapids, and a ~13% reduction (6.2k => 5.3k cycles) on AMD Turin. Cc: Manali Shukla <manali.shukla@amd.com> Tested-by: Xudong Hao <xudong.hao@intel.com> Tested-by: Manali Shukla <manali.shukla@amd.com> Link: https://patch.msgid.link/20251206001720.468579-35-seanjc@google.com Signed-off-by: Sean Christopherson <seanjc@google.com>
1 parent 860bcb1 commit b0b6a8d

1 file changed

Lines changed: 4 additions & 2 deletions

File tree

arch/x86/kvm/pmu.c

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1312,13 +1312,15 @@ static void kvm_pmu_load_guest_pmcs(struct kvm_vcpu *vcpu)
13121312
for (i = 0; i < pmu->nr_arch_gp_counters; i++) {
13131313
pmc = &pmu->gp_counters[i];
13141314

1315-
wrmsrl(gp_counter_msr(i), pmc->counter);
1315+
if (pmc->counter != rdpmc(i))
1316+
wrmsrl(gp_counter_msr(i), pmc->counter);
13161317
wrmsrl(gp_eventsel_msr(i), pmc->eventsel_hw);
13171318
}
13181319
for (i = 0; i < pmu->nr_arch_fixed_counters; i++) {
13191320
pmc = &pmu->fixed_counters[i];
13201321

1321-
wrmsrl(fixed_counter_msr(i), pmc->counter);
1322+
if (pmc->counter != rdpmc(INTEL_PMC_FIXED_RDPMC_BASE | i))
1323+
wrmsrl(fixed_counter_msr(i), pmc->counter);
13221324
}
13231325
}
13241326

0 commit comments

Comments
 (0)