wkup_m3_ipc.c: Fix error checking for debugfs_create_dir

osmten · nmenon · commit b11403c93b7c · 2023-06-06T13:50:52.000-05:00
This patch fixes the error checking in wkup_m3_ipc.c in debugfs_create_dir. The correct way to check if an error occurred is 'IS_ERR' inline function. Signed-off-by: Osama Muhammad <osmtendev@gmail.com> Link: https://lore.kernel.org/r/20230517172431.13507-1-osmtendev@gmail.com Signed-off-by: Nishanth Menon <nm@ti.com>
diff --git a/drivers/soc/ti/wkup_m3_ipc.c b/drivers/soc/ti/wkup_m3_ipc.c
@@ -202,7 +202,7 @@ static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc)
 {
 	m3_ipc->dbg_path = debugfs_create_dir("wkup_m3_ipc", NULL);
 
-	if (!m3_ipc->dbg_path)
+	if (IS_ERR(m3_ipc->dbg_path))
 		return -EINVAL;
 
 	(void)debugfs_create_file("enable_late_halt", 0644,

Original file line number	Diff line number	Diff line change
`@@ -202,7 +202,7 @@ static int wkup_m3_ipc_dbg_init(struct wkup_m3_ipc *m3_ipc)`
`202`	`202`	`{`
`203`	`203`	`m3_ipc->dbg_path = debugfs_create_dir("wkup_m3_ipc", NULL);`
`204`	`204`
`205`		`- if (!m3_ipc->dbg_path)`
	`205`	`+ if (IS_ERR(m3_ipc->dbg_path))`
`206`	`206`	`return -EINVAL;`
`207`	`207`
`208`	`208`	`(void)debugfs_create_file("enable_late_halt", 0644,`