Skip to content

Commit b12e5c6

Browse files
Christoph Hellwigaxboe
authored andcommitted
blk-mq: pass a flags argument to blk_mq_add_to_requeue_list
Replace the boolean at_head argument with the same flags that are already passed to blk_mq_insert_request. Signed-off-by: Christoph Hellwig <hch@lst.de> Reviewed-by: Damien Le Moal <dlemoal@kernel.org> Link: https://lore.kernel.org/r/20230413064057.707578-21-hch@lst.de Signed-off-by: Jens Axboe <axboe@kernel.dk>
1 parent 93fffe1 commit b12e5c6

3 files changed

Lines changed: 6 additions & 6 deletions

File tree

block/blk-flush.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,7 @@ static void blk_flush_complete_seq(struct request *rq,
188188

189189
case REQ_FSEQ_DATA:
190190
list_move_tail(&rq->flush.list, &fq->flush_data_in_flight);
191-
blk_mq_add_to_requeue_list(rq, true);
191+
blk_mq_add_to_requeue_list(rq, BLK_MQ_INSERT_AT_HEAD);
192192
blk_mq_kick_requeue_list(q);
193193
break;
194194

@@ -346,7 +346,7 @@ static void blk_kick_flush(struct request_queue *q, struct blk_flush_queue *fq,
346346
smp_wmb();
347347
req_ref_set(flush_rq, 1);
348348

349-
blk_mq_add_to_requeue_list(flush_rq, false);
349+
blk_mq_add_to_requeue_list(flush_rq, BLK_MQ_INSERT_AT_HEAD);
350350
blk_mq_kick_requeue_list(q);
351351
}
352352

block/blk-mq.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1419,7 +1419,7 @@ void blk_mq_requeue_request(struct request *rq, bool kick_requeue_list)
14191419
/* this request will be re-inserted to io scheduler queue */
14201420
blk_mq_sched_requeue_request(rq);
14211421

1422-
blk_mq_add_to_requeue_list(rq, true);
1422+
blk_mq_add_to_requeue_list(rq, BLK_MQ_INSERT_AT_HEAD);
14231423

14241424
if (kick_requeue_list)
14251425
blk_mq_kick_requeue_list(q);
@@ -1464,7 +1464,7 @@ static void blk_mq_requeue_work(struct work_struct *work)
14641464
blk_mq_run_hw_queues(q, false);
14651465
}
14661466

1467-
void blk_mq_add_to_requeue_list(struct request *rq, bool at_head)
1467+
void blk_mq_add_to_requeue_list(struct request *rq, blk_insert_t insert_flags)
14681468
{
14691469
struct request_queue *q = rq->q;
14701470
unsigned long flags;
@@ -1476,7 +1476,7 @@ void blk_mq_add_to_requeue_list(struct request *rq, bool at_head)
14761476
BUG_ON(rq->rq_flags & RQF_SOFTBARRIER);
14771477

14781478
spin_lock_irqsave(&q->requeue_lock, flags);
1479-
if (at_head) {
1479+
if (insert_flags & BLK_MQ_INSERT_AT_HEAD) {
14801480
rq->rq_flags |= RQF_SOFTBARRIER;
14811481
list_add(&rq->queuelist, &q->requeue_list);
14821482
} else {

block/blk-mq.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ int blk_mq_update_nr_requests(struct request_queue *q, unsigned int nr);
4747
void blk_mq_wake_waiters(struct request_queue *q);
4848
bool blk_mq_dispatch_rq_list(struct blk_mq_hw_ctx *hctx, struct list_head *,
4949
unsigned int);
50-
void blk_mq_add_to_requeue_list(struct request *rq, bool at_head);
50+
void blk_mq_add_to_requeue_list(struct request *rq, blk_insert_t insert_flags);
5151
void blk_mq_flush_busy_ctxs(struct blk_mq_hw_ctx *hctx, struct list_head *list);
5252
struct request *blk_mq_dequeue_from_ctx(struct blk_mq_hw_ctx *hctx,
5353
struct blk_mq_ctx *start);

0 commit comments

Comments
 (0)