Skip to content

Commit b178ad6

Browse files
jailuthragregkh
authored andcommitted
staging: vc04_services: Cleanup VCHIQ TODO entries
Raspberry Pi downstream drivers using VCHIQ have changed a lot since kernel version 4.4 mentioned in the TODO, and are tangential to the destaing process - so drop those items from the list. Secondly, the code indentation for the vchiq interface driver is not so bad anymore since Umang's series (linked below) got merged, so drop it from the TODO. Link: https://lore.kernel.org/all/20241013112128.397249-1-umang.jain@ideasonboard.com/ Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Jai Luthra <jai.luthra@ideasonboard.com> Reviewed-by: Stefan Wahren <wahrenst@gmx.net> Link: https://patch.msgid.link/20251029-vchiq-destage-v3-5-da8d6c83c2c5@ideasonboard.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent bf9f0b0 commit b178ad6

1 file changed

Lines changed: 0 additions & 24 deletions

File tree

  • drivers/staging/vc04_services/interface
Lines changed: 0 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,4 @@
1-
* Import drivers using VCHI.
2-
3-
VCHI is just a tool to let drivers talk to the firmware. Here are
4-
some of the ones we want:
5-
6-
- vc_mem (https://github.com/raspberrypi/linux/blob/rpi-4.4.y/drivers/char/broadcom/vc_mem.c)
7-
8-
This driver is what the vcdbg userspace program uses to set up its
9-
requests to the firmware, which are transmitted across VCHIQ. vcdbg
10-
is really useful for debugging firmware interactions.
11-
12-
- VCSM (https://github.com/raspberrypi/linux/tree/rpi-4.4.y/drivers/char/broadcom/vc_sm)
13-
14-
This driver is used for talking about regions of VC memory across
15-
firmware protocols including VCHI. We'll want to extend this driver
16-
to manage these buffers as dmabufs so that we can zero-copy import
17-
camera images into vc4 for rendering/display.
18-
191
* Documentation
202

213
A short top-down description of this driver's architecture (function of
224
kthreads, userspace, limitations) could be very helpful for reviewers.
23-
24-
* Reformat core code with more sane indentations
25-
26-
The code follows the 80 characters limitation yet tends to go 3 or 4 levels of
27-
indentation deep making it very unpleasant to read. This is specially relevant
28-
in the character driver ioctl code and in the core thread functions.

0 commit comments

Comments
 (0)