evm: Complete description of evm_inode_setattr()

robertosassu · mimizohar · commit b1de86d4248b · 2023-06-05T09:04:41.000-04:00
Add the description for missing parameters of evm_inode_setattr() to avoid the warning arising with W=n compile option. Fixes: 817b54a ("evm: add evm_inode_setattr to prevent updating an invalid security.evm") # v3.2+ Fixes: c1632a0 ("fs: port ->setattr() to pass mnt_idmap") # v6.3+ Signed-off-by: Roberto Sassu <roberto.sassu@huawei.com> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com> Signed-off-by: Mimi Zohar <zohar@linux.ibm.com>
diff --git a/security/integrity/evm/evm_main.c b/security/integrity/evm/evm_main.c
@@ -795,7 +795,9 @@ static int evm_attr_change(struct mnt_idmap *idmap,
 
 /**
  * evm_inode_setattr - prevent updating an invalid EVM extended attribute
+ * @idmap: idmap of the mount
  * @dentry: pointer to the affected dentry
+ * @attr: iattr structure containing the new file attributes
  *
  * Permit update of file attributes when files have a valid EVM signature,
  * except in the case of them having an immutable portable signature.

Original file line number	Diff line number	Diff line change
`@@ -795,7 +795,9 @@ static int evm_attr_change(struct mnt_idmap *idmap,`
`795`	`795`
`796`	`796`	`/**`
`797`	`797`	`* evm_inode_setattr - prevent updating an invalid EVM extended attribute`
	`798`	`+ * @idmap: idmap of the mount`
`798`	`799`	`* @dentry: pointer to the affected dentry`
	`800`	`+ * @attr: iattr structure containing the new file attributes`
`799`	`801`	`*`
`800`	`802`	`* Permit update of file attributes when files have a valid EVM signature,`
`801`	`803`	`* except in the case of them having an immutable portable signature.`