Skip to content

Commit b227be0

Browse files
Marc ZyngierLorenzo Pieralisi
authored andcommitted
PCI/MSI: Kill msi_controller structure
msi_controller had a good, long life as the abstraction for a driver providing MSIs to PCI devices. But it has been replaced in all drivers by the more expressive generic MSI framework. Farewell, struct msi_controller. Link: https://lore.kernel.org/r/20210330151145.997953-9-maz@kernel.org Signed-off-by: Marc Zyngier <maz@kernel.org> Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
1 parent 3a05d08 commit b227be0

1 file changed

Lines changed: 1 addition & 15 deletions

File tree

include/linux/msi.h

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -240,8 +240,7 @@ void pci_msi_unmask_irq(struct irq_data *data);
240240
/*
241241
* The arch hooks to setup up msi irqs. Default functions are implemented
242242
* as weak symbols so that they /can/ be overriden by architecture specific
243-
* code if needed. These hooks must be enabled by the architecture or by
244-
* drivers which depend on them via msi_controller based MSI handling.
243+
* code if needed. These hooks can only be enabled by the architecture.
245244
*
246245
* If CONFIG_PCI_MSI_ARCH_FALLBACKS is not selected they are replaced by
247246
* stubs with warnings.
@@ -272,19 +271,6 @@ static inline void arch_teardown_msi_irqs(struct pci_dev *dev)
272271
void arch_restore_msi_irqs(struct pci_dev *dev);
273272
void default_restore_msi_irqs(struct pci_dev *dev);
274273

275-
struct msi_controller {
276-
struct module *owner;
277-
struct device *dev;
278-
struct device_node *of_node;
279-
struct list_head list;
280-
281-
int (*setup_irq)(struct msi_controller *chip, struct pci_dev *dev,
282-
struct msi_desc *desc);
283-
int (*setup_irqs)(struct msi_controller *chip, struct pci_dev *dev,
284-
int nvec, int type);
285-
void (*teardown_irq)(struct msi_controller *chip, unsigned int irq);
286-
};
287-
288274
#ifdef CONFIG_GENERIC_MSI_IRQ_DOMAIN
289275

290276
#include <linux/irqhandler.h>

0 commit comments

Comments
 (0)