Skip to content

Commit b236371

Browse files
athira-rajeevacmel
authored andcommitted
perf test topology: Use !strncmp(right platform) to fix guest PPC comparision check
commit cfd7092 ("perf test session topology: Fix test to skip the test in guest environment") added check to skip the testcase if the socket_id can't be fetched from topology info. But the condition check uses strncmp which should be changed to !strncmp and to correctly match platform. Fix this condition check. Fixes: cfd7092 ("perf test session topology: Fix test to skip the test in guest environment") Reported-by: Thomas Richter <tmricht@linux.ibm.com> Signed-off-by: Athira Jajeev <atrajeev@linux.vnet.ibm.com> Acked-by: Ian Rogers <irogers@google.com> Cc: Athira Rajeev <atrajeev@linux.vnet.ibm.com> Cc: Disha Goel <disgoel@linux.vnet.ibm.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Kajol Jain <kjain@linux.ibm.com> Cc: linuxppc-dev@lists.ozlabs.org Cc: Madhavan Srinivasan <maddy@linux.ibm.com> Cc: Michael Ellerman <mpe@ellerman.id.au> Cc: Nageswara R Sastry <rnsastry@linux.ibm.com> Link: https://lore.kernel.org/r/20220610135939.63361-1-atrajeev@linux.vnet.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
1 parent 72dcae8 commit b236371

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

tools/perf/tests/topology.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ static int check_cpu_topology(char *path, struct perf_cpu_map *map)
115115
* physical_package_id will be set to -1. Hence skip this
116116
* test if physical_package_id returns -1 for cpu from perf_cpu_map.
117117
*/
118-
if (strncmp(session->header.env.arch, "powerpc", 7)) {
118+
if (!strncmp(session->header.env.arch, "ppc64le", 7)) {
119119
if (cpu__get_socket_id(perf_cpu_map__cpu(map, 0)) == -1)
120120
return TEST_SKIP;
121121
}

0 commit comments

Comments
 (0)