Skip to content

Commit b26f965

Browse files
Yihao Hanbroonie
authored andcommitted
ASoC: SOF: topology: Use kmemdup() to replace kzalloc + memcpy
fix memdup.cocci warning: sound/soc/sof/topology.c:876:19-26: WARNING opportunity for kmemdup Generated by: scripts/coccinelle/api/memdup.cocci Signed-off-by: Yihao Han <hanyihao@vivo.com> Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20220317093841.3414-1-hanyihao@vivo.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent 753132f commit b26f965

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

sound/soc/sof/topology.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -873,11 +873,10 @@ static int sof_control_load_bytes(struct snd_soc_component *scomp,
873873

874874
/* copy the private data */
875875
if (priv_size > 0) {
876-
scontrol->priv = kzalloc(priv_size, GFP_KERNEL);
876+
scontrol->priv = kmemdup(control->priv.data, priv_size, GFP_KERNEL);
877877
if (!scontrol->priv)
878878
return -ENOMEM;
879879

880-
memcpy(scontrol->priv, control->priv.data, priv_size);
881880
scontrol->priv_size = priv_size;
882881
}
883882

0 commit comments

Comments
 (0)