Skip to content

Commit b2b701b

Browse files
committed
dt-bindings: pinctrl: Allow values for drive-push-pull and drive-open-drain
A few platforms, at91 and tegra, use drive-push-pull and drive-open-drain with a 0 or 1 value. There's not really a need for values as '1' should be equivalent to no value (it wasn't treated that way) and drive-push-pull disabled is equivalent to drive-open-drain. So dropping the value can't be done without breaking existing OSs. As we don't want new cases, mark the case with values as deprecated. Cc: Arnd Bergmann <arnd@arndb.de> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Jonathan Hunter <jonathanh@nvidia.com> Cc: Nicolas Ferre <nicolas.ferre@microchip.com> Cc: Claudiu Beznea <claudiu.beznea@microchip.com> Signed-off-by: Rob Herring <robh@kernel.org> Link: https://lore.kernel.org/r/20220429194610.2741437-1-robh@kernel.org
1 parent e17fd4b commit b2b701b

1 file changed

Lines changed: 10 additions & 2 deletions

File tree

Documentation/devicetree/bindings/pinctrl/pincfg-node.yaml

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,11 +52,19 @@ properties:
5252
hardware supporting it the pull strength in Ohm.
5353

5454
drive-push-pull:
55-
type: boolean
55+
oneOf:
56+
- type: boolean
57+
- $ref: /schemas/types.yaml#/definitions/uint32
58+
enum: [ 0, 1 ]
59+
deprecated: true
5660
description: drive actively high and low
5761

5862
drive-open-drain:
59-
type: boolean
63+
oneOf:
64+
- type: boolean
65+
- $ref: /schemas/types.yaml#/definitions/uint32
66+
const: 1 # No known cases of 0
67+
deprecated: true
6068
description: drive with open drain
6169

6270
drive-open-source:

0 commit comments

Comments
 (0)