Skip to content

Commit b2ff1bd

Browse files
jtlaytonchucklever
authored andcommitted
nfsd: don't take/put an extra reference when putting a file
The last thing that filp_close does is an fput, so don't bother taking and putting the extra reference. Signed-off-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent b680cb9 commit b2ff1bd

1 file changed

Lines changed: 1 addition & 3 deletions

File tree

fs/nfsd/filecache.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -382,10 +382,8 @@ nfsd_file_free(struct nfsd_file *nf)
382382
if (nf->nf_mark)
383383
nfsd_file_mark_put(nf->nf_mark);
384384
if (nf->nf_file) {
385-
get_file(nf->nf_file);
386-
filp_close(nf->nf_file, NULL);
387385
nfsd_file_check_write_error(nf);
388-
fput(nf->nf_file);
386+
filp_close(nf->nf_file, NULL);
389387
}
390388

391389
/*

0 commit comments

Comments
 (0)