Skip to content

Commit b327708

Browse files
Zenghui YuKAGA-KOKO
authored andcommitted
irqchip/loongson-pch-msi: Fix off-by-one on allocation error path
When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one in the number of interrupts to be freed. Fix it by passing the number of successfully allocated interrupts, instead of the relative index of the last allocated one. Fixes: 632dcc2 ("irqchip: Add Loongson PCH MSI controller") Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Link: https://lore.kernel.org/r/20240327142334.1098-1-yuzenghui@huawei.com
1 parent ff3669a commit b327708

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/irqchip/irq-loongson-pch-msi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain,
136136

137137
err_hwirq:
138138
pch_msi_free_hwirq(priv, hwirq, nr_irqs);
139-
irq_domain_free_irqs_parent(domain, virq, i - 1);
139+
irq_domain_free_irqs_parent(domain, virq, i);
140140

141141
return err;
142142
}

0 commit comments

Comments
 (0)