Skip to content

Commit b33aa90

Browse files
vladimirolteankuba-moo
authored andcommitted
net: dsa: tag_rzn1_a5psw: use the dsa_xmit_port_mask() helper
The "a5psw" tagging protocol populates a bit mask for the TX ports, so we can use dsa_xmit_port_mask() to centralize the decision of how to set that field. Cc: "Clément Léger" <clement.leger@bootlin.com> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com> Link: https://patch.msgid.link/20251127120902.292555-13-vladimir.oltean@nxp.com Signed-off-by: Jakub Kicinski <kuba@kernel.org>
1 parent 5afe4cc commit b33aa90

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

net/dsa/tag_rzn1_a5psw.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,6 @@ struct a5psw_tag {
3939

4040
static struct sk_buff *a5psw_tag_xmit(struct sk_buff *skb, struct net_device *dev)
4141
{
42-
struct dsa_port *dp = dsa_user_to_port(dev);
4342
struct a5psw_tag *ptag;
4443
u32 data2_val;
4544

@@ -60,7 +59,7 @@ static struct sk_buff *a5psw_tag_xmit(struct sk_buff *skb, struct net_device *de
6059

6160
ptag = dsa_etype_header_pos_tx(skb);
6261

63-
data2_val = FIELD_PREP(A5PSW_CTRL_DATA_PORT, BIT(dp->index));
62+
data2_val = FIELD_PREP(A5PSW_CTRL_DATA_PORT, dsa_xmit_port_mask(skb, dev));
6463
ptag->ctrl_tag = htons(ETH_P_DSA_A5PSW);
6564
ptag->ctrl_data = htons(A5PSW_CTRL_DATA_FORCE_FORWARD);
6665
ptag->ctrl_data2_lo = htons(data2_val);

0 commit comments

Comments
 (0)