Skip to content

Commit b3bebe4

Browse files
surenbaghdasaryanakpm00
authored andcommitted
alloc_tag: outline and export free_reserved_page()
Outline and export free_reserved_page() because modules use it and it in turn uses page_ext_{get|put} which should not be exported. The same result could be obtained by outlining {get|put}_page_tag_ref() but that would have higher performance impact as these functions are used in more performance critical paths. Link: https://lkml.kernel.org/r/20240717212844.2749975-1-surenb@google.com Fixes: dcfe378 ("lib: introduce support for page allocation tagging") Signed-off-by: Suren Baghdasaryan <surenb@google.com> Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407080044.DWMC9N9I-lkp@intel.com/ Suggested-by: Christoph Hellwig <hch@infradead.org> Suggested-by: Vlastimil Babka <vbabka@suse.cz> Acked-by: Vlastimil Babka <vbabka@suse.cz> Cc: Kees Cook <keescook@chromium.org> Cc: Kent Overstreet <kent.overstreet@linux.dev> Cc: Pasha Tatashin <pasha.tatashin@soleen.com> Cc: Sourav Panda <souravpanda@google.com> Cc: <stable@vger.kernel.org> [6.10] Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent bf6acd5 commit b3bebe4

2 files changed

Lines changed: 18 additions & 15 deletions

File tree

include/linux/mm.h

Lines changed: 1 addition & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -3137,21 +3137,7 @@ extern void reserve_bootmem_region(phys_addr_t start,
31373137
phys_addr_t end, int nid);
31383138

31393139
/* Free the reserved page into the buddy system, so it gets managed. */
3140-
static inline void free_reserved_page(struct page *page)
3141-
{
3142-
if (mem_alloc_profiling_enabled()) {
3143-
union codetag_ref *ref = get_page_tag_ref(page);
3144-
3145-
if (ref) {
3146-
set_codetag_empty(ref);
3147-
put_page_tag_ref(ref);
3148-
}
3149-
}
3150-
ClearPageReserved(page);
3151-
init_page_count(page);
3152-
__free_page(page);
3153-
adjust_managed_page_count(page, 1);
3154-
}
3140+
void free_reserved_page(struct page *page);
31553141
#define free_highmem_page(page) free_reserved_page(page)
31563142

31573143
static inline void mark_page_reserved(struct page *page)

mm/page_alloc.c

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5815,6 +5815,23 @@ unsigned long free_reserved_area(void *start, void *end, int poison, const char
58155815
return pages;
58165816
}
58175817

5818+
void free_reserved_page(struct page *page)
5819+
{
5820+
if (mem_alloc_profiling_enabled()) {
5821+
union codetag_ref *ref = get_page_tag_ref(page);
5822+
5823+
if (ref) {
5824+
set_codetag_empty(ref);
5825+
put_page_tag_ref(ref);
5826+
}
5827+
}
5828+
ClearPageReserved(page);
5829+
init_page_count(page);
5830+
__free_page(page);
5831+
adjust_managed_page_count(page, 1);
5832+
}
5833+
EXPORT_SYMBOL(free_reserved_page);
5834+
58185835
static int page_alloc_cpu_dead(unsigned int cpu)
58195836
{
58205837
struct zone *zone;

0 commit comments

Comments
 (0)