Skip to content

Commit b423e54

Browse files
Xiaomeng Tongdavem330
authored andcommitted
myri10ge: fix an incorrect free for skb in myri10ge_sw_tso
All remaining skbs should be released when myri10ge_xmit fails to transmit a packet. Fix it within another skb_list_walk_safe. Signed-off-by: Xiaomeng Tong <xiam0nd.tong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent afb8e24 commit b423e54

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

drivers/net/ethernet/myricom/myri10ge/myri10ge.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2903,11 +2903,9 @@ static netdev_tx_t myri10ge_sw_tso(struct sk_buff *skb,
29032903
status = myri10ge_xmit(curr, dev);
29042904
if (status != 0) {
29052905
dev_kfree_skb_any(curr);
2906-
if (segs != NULL) {
2907-
curr = segs;
2908-
segs = next;
2906+
skb_list_walk_safe(next, curr, next) {
29092907
curr->next = NULL;
2910-
dev_kfree_skb_any(segs);
2908+
dev_kfree_skb_any(curr);
29112909
}
29122910
goto drop;
29132911
}

0 commit comments

Comments
 (0)